On Wed, Jan 04, 2012 at 11:12:49AM +0100, Juergen Beisert wrote: > Michael Olbrich wrote: [...] > > > +ifdef PTXCONF_KMOD_LOGGING > > > +KMOD_CONF_OPT += --enable-logging > > > +else > > > +KMOD_CONF_OPT += --disable-logging > > > +endif > > > > please use ptx/endis. It's shorter and you can sort all parameters as > > listed in "configure --help" that makes updates much easier. > > Okay. Didn't really noticed this macro yet.
It wasn't really used for a long time, but I think it makes the configure options much more readable. > > [...] > > > > > +ifdef PTXCONF_KMOD_TOOLS > > > + @for file in kmod-insmod kmod-lsmod kmod-modinfo kmod-modprobe > > > kmod-rmmod; \ > > > + do \ > > > + $(call install_copy, kmod, 0, 0, 0755, -, > > > /usr/bin/$$file); \ > > > + done > > > +endif > > > > How do these compare to the 'real' tool? While this is nice for testing, > > it would be nice if we could only install these. > > They should replace the current used tools in the long term. Main goal for > this package is the library, as it will be used in the future by 'udev'. > > > I'd use $(foreach ...) but that's no big issue. > > Another macro I'm not a aware off? That's just plain make syntax $(foreach var, list, expression). Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
