On Wed, Mar 14, 2012 at 11:42:51AM +0100, Michael Olbrich wrote: > On Tue, Mar 13, 2012 at 10:32:16PM +0100, Remy Bohmer wrote: > > Busybox make is not properly called in case: > > * compiler name tuple does not match target tuple (as used in multilib > > compilers, for example: i686-pc-linux-gnu-gcc can compile for > > x86_64-unknown-linux-gnu targets. To solve this the 'SUBARCH' need to be > > set) > > * CONFIG_EXTRA_CFLAGS need to e set to select the proper sysroot to > > compile against in busybox > > * LDFLAGS to link against the proper sysroot. > > > > Signed-off-by: Remy Bohmer <[email protected]> > > --- > > v2: Reworked review comments from Michael Olbrich > > > > rules/busybox.make | 21 ++++++++++++--------- > > 1 files changed, 12 insertions(+), 9 deletions(-) > > > > diff --git a/rules/busybox.make b/rules/busybox.make > > index 536aa80..45fd20f 100644 > > --- a/rules/busybox.make > > +++ b/rules/busybox.make > > @@ -48,15 +48,18 @@ $(STATEDIR)/busybox.prepare: > > @$(call touch) > > > > BUSYBOX_MAKE_OPT := \ > > - ARCH=$(PTXCONF_ARCH_STRING) \ > > - CROSS_COMPILE=$(COMPILER_PREFIX) \ > > - CONFIG_EXTRA_CFLAGS="$(CROSS_CFLAGS)" \ > > - HOSTCC=$(HOSTCC) \ > > - SKIP_STRIP=y > > - > > -ifdef PTXCONF_BUSYBOX_RFKILL > > -BUSYBOX_MAKE_OPT += CFLAGS="-I$(KERNEL_HEADERS_INCLUDE_DIR)" > > -endif > > + ARCH=$(PTXCONF_ARCH_STRING) \ > > + SUBARCH=$(PTXCONF_ARCH_STRING) \ > > + CROSS_COMPILE=$(COMPILER_PREFIX) \ > > + HOSTCC=$(HOSTCC) > > Indent with on <tab> everywhere. > > > + > > +BUSYBOX_MAKE_ENV := \ > > + $(CROSS_ENV) \ > > + CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)" > > + SKIP_STRIP=y > > Looks like SKIP_STRIP=y must be in BUSYBOX_MAKE_OPT, or it's not used.
No wait, you're just missing '\' at the end of the previous line. Michael > > + > > +BUSYBOX_INSTAL_ENV := \ > > install with 2 'L' > > Michael > > > + $(BUSYBOX_MAKE_ENV) > > > > BUSYBOX_INSTALL_OPT := \ > > $(BUSYBOX_MAKE_OPT) \ > > -- > > 1.7.5.4 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
