> > > FLASHBENCH_CONF_TOOL := NO > > > FLASHBENCH_MAKE_ENV := $(CROSS_ENV) > > > -FLASHBENCH_MAKE_OPT := CC=$(CROSS_CC) \ > > > > Please add a comment here. Otherwise it it not clear why this is needed. > > Then we should discuss about comments in the changed files or in the change > itself.
In a comment, you describe why it is _done_ that way. In a commit message, you describe why it needs to be _changed_ that way. Those two can be quite similar, but often are not. When in doubt, redundancy is your friend here :) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
-- ptxdist mailing list [email protected]
