Hi, On Thu, Aug 30, 2012 at 11:29:25AM +0200, Alexander Dahl wrote: > Am 2012-08-21 11:32, schrieb Michael Olbrich: > >> 1) There's a way to test in the make file if openssl is activated in > >> the collection and I missed it. > > > > ifneq ($(filter openssl,$(PACKAGES)),) > > ... > > endif > > > > I think. I would not recommend this. This will break if you switch > > collections without rebuilding everything. > > Also, you need to depend on openssl to make sure the file is already > > available. > > A question came to my mind: why is "ifdef PTXCONF_FOO" true in the > first place when FOO=m in the ptxconfig and FOO is not set in the > collectionconfig? If collections are used, why wouldn't you wanna check > the collectionconfig if a package is activated instead of the ptxconfig?
Well historically the answer is, because it's easier and should make no difference. ptxconfig and collectionconfig are just sourced into the Makefile. 'ifdef PTXCONF_FOO' is to setup variables etc. and 'PACKAGES-$(PTXCONF_FOO) += foo' is to enable the package. In any generic code this is important, because there are platform specific packages that cannot be built, even with 'PTXCONF_FOO=y'. I had a patch at some point, that removed any PTXCONF_FOO=m lines when working with collections. I never applied it because there was no real benefit. Also, creating multiple images from different collectionconfigs in one go is on my todo list. I'm not quite sure how to implement this, but it's quite possible that the concept of one list with all packages to built will go away at some point. There will only be 'can be built' == 'ifdef PTXCONF_FOO' or 'is built' == 'something depends on install/targetinstall' Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
