On Sat, Dec 08, 2012 at 04:22:27AM +0400, Kirill Smirnov wrote:
> Please, any feedback on this. Did I do anything wrong?

I forgot about this.

> On 21.11.2012 02:07, Kirill Smirnov wrote:
> >The attached patch correctly sets up CPPFLAGS variable for sqlite
> >package and contains a minor cosmetic fix.

Please end a canonical patch (with 'git sent-email' or (git format-patch').

> >Otherwise configure script cannot find external libraries and headers
> >(such as readline).

Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
why you're getting this error and I don't.

> >--
> >Kirill
> >
> >
> > diff --git a/rules/sqlite.make b/rules/sqlite.make
> > index 0ff4c86..25ff3b7 100644
> > --- a/rules/sqlite.make
> > +++ b/rules/sqlite.make
> > @@ -34,12 +34,13 @@ SQLITE_LICENSE  := public_domain
> >  # 
> > ----------------------------------------------------------------------------
> 
> >  SQLITE_CONF_ENV := \
> > -   CPPFLAGS=" \
> > +   $(CROSS_ENV) \

This looks ok.

> > +   CPPFLAGS="$(CROSS_CPPFLAGS) \

With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
not needed any more.

Michael

> >     -DSQLITE_ENABLE_COLUMN_METADATA \
> >     -DSQLITE_ENABLE_FTS3 \
> >     -DSQLITE_ENABLE_RTREE=1 \
> >     -DSQLITE_ENABLE_UNLOCK_NOTIFY \
> > -   -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
> > +   -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
> >     -DSQLITE_OMIT_LOOKASIDE=1 \
> >     -DSQLITE_SECURE_DELETE \
> >     -DSQLITE_SOUNDEX=1 \
> 
> 
> -- 
> ptxdist mailing list
> [email protected]
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to