Hi, On Mon, Feb 03, 2014 at 08:04:18AM +0100, Uwe Kleine-König wrote: > On Sat, Feb 01, 2014 at 05:42:51PM -0500, [email protected] wrote: > > From: Jon Ringle <[email protected]> > > > > Allow a git repo to be specified with ssh://*.git > > > > Signed-off-by: Jon Ringle <[email protected]> > > --- > > scripts/lib/ptxd_make_get.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh > > index 9f388dd..26b99d5 100644 > > --- a/scripts/lib/ptxd_make_get.sh > > +++ b/scripts/lib/ptxd_make_get.sh > > @@ -332,7 +332,7 @@ ptxd_make_get() { > > shift > > > > case "${url}" in > > - git://*|http://*.git|https://*.git) > > + git://*|http://*.git|https://*.git|ssh://*.git) > the more standard git-URL is: > > hostname:/path/to/repo.git > > maybe add that(, too| instead)?
No. It schould be clear that the URL is actually an URL, so it should start with "<something>://". I wouln't mind adding more patterns, but only if the URL cannot be expressed using the existing ones, e.g. file, or ftp URLs. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
