Hi,
since I'm also using ct-ng toolchains, I like that feature. However,
in my case CT_TOOLCHAIN_PKGVERSION was empty, so wouldn't it make sense
to add the line
[ -z "$vendor_is" ] && vendor_is=crosstool-NG
after
vendor_is=$(${ct_vendor_def} | sed -n -e 's/"//g' -e
's/^CT_TOOLCHAIN_PKGVERSION=//p')
(sorry, I don't have the original patch in my mail box).
From the ct-ng help text:
│ ┌── Toolchain ID string
─────────────────────────────────────────────────┐ │
│ │
│ │
│ │ CT_TOOLCHAIN_PKGVERSION:
│ │
│ │
│ │
│ │ Specify a string that identifies your package. You may
wish to include │ │
│ │ a build number or build date. This version string will be
included in │ │
│ │ the output of gcc --version, and also in binutils,
eglibc, gdb and │ │
│ │ gdbserver.
│ │
│ │
│ │
│ │ If this string is left empty, the actual package version
will be: │ │
│ │ "crosstool-NG ${CT_VERSION}"
│ │
│ │ Otherwise, it will be:
│ │
│ │ "crosstool-NG ${CT_VERSION} -
${CT_TOOLCHAIN_PKGVERSION}" │ │
│ │
│ │
│ │ This is passed to the configure flag --with-pkgversion.
│ │
│ │
│ │
│ │ Symbol: TOOLCHAIN_PKGVERSION [=]
│ │
│ │ Type : string
│ │
│ │ Prompt: Toolchain ID string
│ │
│ │ Defined at config/toolchain.in:73
│ │
│ │ Location:
│ │
│ │ -> Toolchain options
│ │
│ │
│ │
│ │
│ │
│ │
│ │
│ │ <OK>
│ │
│
└────────────────────────────────────────────────────────────────────────┘ │
Maybe it would be nice to include the version in the check, but the only
line
where I could find the version of ct-ng in ${TARGET}-ct-ng.config is the
header comment:
# crosstool-NG 1.19.0 Configuration
Don't know if it makes sense to parse that.
Regards,
Bernhard
Am 2014-03-16 17:07, schrieb Andreas Bießmann:
On 20.02.14 14:28, Andreas Bießmann wrote:
Before the toolchain vendor check was dedicated to OSELAS.Toolchain.
This patch introduces this feature to a toolchain built with ct-ng.
Signed-off-by: Andreas Bießmann <[email protected]>
---
I know that Pengutronix develops and distributes OSELAS.Toolchain. I
switched
however for some targets to the ct-ng toolchain and found the really
useful
feature of toolchain versioning broken when using that other
toolchain. This
patch is hopefully even so accepted ;)
any comments?
--
ptxdist mailing list
[email protected]
