On Mon, May 26, 2014 at 09:13:25AM +0200, Alexander Dahl wrote:
> Am 2014-05-21 17:03, schrieb Alexander Dahl:
> > I'm not sure how to fix this, no time anymore today, so I let you know
> > this way.
>
> Though I'm not entirely certain about some things in Makefiles I have a
> solution which works for me:
>
>
> % colordiff -bus ~/src/ptxdist/rules/post/image_tgz.make
> rules/post/image_tgz.make :(
> --- /home/adahl/src/ptxdist/rules/post/image_tgz.make 2014-04-28
> 12:59:13.430666724 +0200
> +++ rules/post/image_tgz.make 2014-05-26 09:00:10.981436285 +0200
> @@ -13,7 +13,7 @@
> ifdef PTXCONF_IMAGE_TGZ
> IMAGE_TGZ_LABEL := $(call remove_quotes,$(PTXCONF_IMAGE_TGZ_LABEL))
> ifneq ($(IMAGE_TGZ_LABEL),)
> -IMAGE_TGZ_LABEL_ARGS="--label '$(IMAGE_TGZ_LABEL)'"
> +IMAGE_TGZ_LABEL_ARGS=--label '$(IMAGE_TGZ_LABEL)'
> endif
>
> $(IMAGEDIR)/root.tgz: $(STATEDIR)/image_working_dir
>
>
> So I removed the quotes when assigning IMAGE_TGZ_LABEL_ARGS because
> later in line 23 ${IMAGE_TGZ_LABEL_ARGS} was expanded to "something"
> which led to
>
> echo -n "tar "--label 'foo bar baz-myproject-2014.03.1'" -zcf ";
>
> which is obviously wrong. With my change this is
>
> echo -n "tar --label 'foo bar baz-myproject-2014.03.1' -zcf ";
>
> But as I said, I'm not sure if this assignement is valid in Makefiles
> and I don't know (yet) what's the difference between $(something) and
> ${something} in a Makefile.
I don't think there is a difference between $(something) and ${something}
in a Makefile. This is the correct fix. I've pushed it.
Thanks,
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
[email protected]
