On Mon, Aug 18, 2014 at 01:34:48PM +0200, Alexander Stein wrote: > On Monday 18 August 2014 09:50:37, Michael Olbrich wrote: > > On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote: > > > Without linemarkers the error messages are somehwat useless. > > > To demonstrate I picked a random .dts file file from the arm tree in > > > linux sources: > > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb > > > Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error > > > FATAL ERROR: Unable to parse input tree > > > > > > If linemarkers are inserted the error message clearly states in which file > > > which line caused the error: > > > > > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb > > > Error: > > > /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 > > > syntax error > > > FATAL ERROR: Unable to parse input tree > > > > I think that means that the dtc must understand these markers, right? This > > will most likely break building device-trees for older kernels. > > AFAICS this included since dtc-1.4.0.
That's v3.6 Kernel version. We cannot depend on that. However, we already have a check for '-i' support in ptxd_make_dts_dtb(). That was introduces in the same commit. I'd accept a patch that adds '-P' only when dtc does not support '-i'. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
