On Thu, Jan 08, 2015 at 01:36:19PM +0100, Martin Hejnfelt wrote: > Hi Michael, > > 2015-01-08 12:58 GMT+01:00 Michael Olbrich <[email protected]>: > > > > Any reason to use java7 and not java8? > > Only reason is that I am developing for Java 7, and want to keep the > compatibility (or at least not introduce any issues, simply for > versioning). In my opinion, you should have both if anything. > > > > >> +config ORACLE_JAVA7_JRE_TARGET_PREFIX > >> + string > >> + depends on ORACLE_JAVA7_JRE > >> + default "/usr/lib/jvm" > >> + prompt "PREFIX for JRE 7" > >> + help > >> + Where should the JRE be installed. > > > > Do we need this? I think we can just hardcode this path. > > > > I agree, I'll change that. > > >> + > >> +# > >> ---------------------------------------------------------------------------- > >> +# Get > >> +# > >> ---------------------------------------------------------------------------- > >> + > >> +$(ORACLE_JAVA7_JRE_SOURCE): > >> + @$(call targetinfo) > >> + wget --no-cookies --header "Cookie: > >> oraclelicense=accept-securebackup-cookie" $(ORACLE_JAVA7_JRE_URL) -P > >> $(SRCDIR)/ > > > > No, this is more complex. I need to think about how to handle this > > correctly. > > > > Yes it's more complex, but right now it's the only way I know to > download it automatically. Suggestions to change are welcome :) > > Should I put up a new patch with the changes mentioned here, and the rest?
Just send it and I'll fix the download part once I know how I want to handle this. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
