On Mon, Mar 23, 2015 at 08:59:42AM +0100, Robert Schwebel wrote:
> Michael,
> 
> On Mon, Mar 23, 2015 at 08:52:00AM +0100, Robert Schwebel wrote:
> > +#
> > +# from   : ptxdist-2015.02.0
> > +# to     : ptxdist-2015.03.0
> > +# symbol : HACKBENCH -> RT_TESTS_HACKBENCH
> > +# reason : old tool obsolete, new version is from rt-tests
> > +#
> > +s/^\(\(# \)PTXCONF_\)HACKBENCH/\1RT_TESTS_HACKBENCH/
> > +s/^PTXCONF_HACKBENCH=\([ym]\)/PTXCONF_RT_TESTS_HACKBENCH=y\nPTXCONF_RT_TESTS=\1/
> 
> I tried the trick you suggested, but I'm still not entirely happy:
> 
> - I get a warning during migration:
>   .config:2062:warning: override: reassigning to symbol RT_TESTS_HACKBENCH

It' only happens once during migrate, and that's ok.

> - There are still cases of RT_TESTS already being set to either y or m
>   where the migration helper does the wrong thing.
> 
> Better ideas, anyone?

I've simplified it a bit while applying, broke it and fixed it again.
It works as I would expect it:

RT_TESTS will remain as is, when it's already enabled. I don't think
anything else makes sense.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to