On Thu, Aug 04, 2016 at 09:57:57AM +0200, Alexander Dahl wrote:
> Am 2016-08-04 08:49, schrieb Michael Olbrich:
> > NCDU_CONF_OPT := \
> > $(CROSS_AUTOCONF_USR) \
> > ...
> >
> > Are you sure there are no other options?
>
> Yes. This tool just needs ncurses in some form, this is the part of
> ./configure with all the options:
>
>
> Optional Packages:
> --with-PACKAGE[=ARG] use PACKAGE [ARG=yes]
> --without-PACKAGE do not use PACKAGE (same as --with-PACKAGE=no)
> --with-ncurses compile/link with ncurses library
> --with-ncursesw compile/link with wide-char ncurses library
> [default]
> --with-shell used interpreter as default shell (default is
> /bin/sh)
ok.
> >> +ifdef PTXCONF_NCURSES_WIDE_CHAR
> >
> > Don't use symbols from other packages. PTXdist won't know when it needs to
> > rebuild your package when the option changes.
>
> Well, someone should go fix alsa-utils then. ;-)
Indeed.
> > Add a local symbol like this:
> >
> > config NCDU_NCURSESW
> > bool
> > default NCURSES_WIDE_CHAR
> >
> >> +NCDU_CONF_OPT += --with-ncursesw
> >
> > Use ptx/wwo for this.
> >
> >> +else
> >> +NCDU_CONF_OPT += --with-ncurses
>
> Maybe I didn't understand this ncurses vs. ncursesw thing correctly yet.
> Isn't it always one xor the other, or are both at the same time
> possible?
I looked at the configure.ac and it's broken :-/. Using --without-ncurses
will still enable it... So use this:
--with-$(call ptx/ifdef,PTXCONF_NCDU_NCURSESW,ncursesw,ncurses)
> > This needs a ptx/wow. That does not exist yet, but it's easy to add.
> > It should be defined in rules/pre/000-option-disabled.make with ptx/wwo
> > just with reversed arguments, just like ptx/endis vs. ptx/disen.
>
> That's easy, I would make a separate patch for that.
I would still appreciate such a patch, even if it's not needed for this.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
