[ptxdist] [RFC] ptxd_make_get_http: Specify the username and password

[Ladislav Michl]

Hi there,

I need to pass username and password to download mercurial snapshot from
server, so something like this now works:
package_URL := 
https://mercurial.site.com/hg/package/archive/$(package_VERSION).$(package_SUFFIX);user=<username>:<password>

Is it acceptable to support it in upstream PTXdist?
(it could be probably rewritten some nicer way, but I'm not too good at shell 
scripting)

        ladis

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index 2bac97817..e392e8b0c 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -25,6 +25,7 @@ ptxd_make_get_http() {
        # scan for valid options
        #
        while [ ${#} -ne 0 ]; do
+               local cred
                local opt="${1}"
                shift
 
@@ -45,6 +46,13 @@ ptxd_make_get_http() {
                                curl_opts[${#curl_opts[@]}]="--cookie"
                                curl_opts[${#curl_opts[@]}]="${opt#cookie:}"
                                ;;
+                       user=*)
+                               cred="${opt#user=}"
+                               cred=(${cred//:/ })
+                               opts[${#opts[@]}]="--user=${cred[0]}"
+                               opts[${#opts[@]}]="--password=${cred[1]}"
+                               curl_opts[${#curl_opts[@]}]="${opt#user=}"
+                               ;;
                        *)
                                ptxd_bailout "invalid option '${opt}' to 
${FUNCNAME}"
                                ;;

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de