On Wed, Sep 20, 2017 at 04:19:50PM +0200, David Jander wrote: > On Thu, 27 Jul 2017 16:31:15 -0400 > [email protected] wrote: > > > From: Jon Ringle <[email protected]> > > > > This fixes unused parameter 'deterministic' issue: > > src/backend-common/backend_ipc.pb.cc:32994:10: error: unused parameter > > 'deterministic' [-Werror=unused-parameter] > > bool deterministic, ::google::protobuf::uint8* target) const { > > ^ > > > > Signed-off-by: Jon Ringle <[email protected]> > > --- > > patches/{protobuf-3.3.1 => protobuf-3.3.2}/autogen.sh | 0 > > rules/protobuf.make | 4 ++-- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > rename patches/{protobuf-3.3.1 => protobuf-3.3.2}/autogen.sh (100%) > > > > diff --git a/patches/protobuf-3.3.1/autogen.sh > > b/patches/protobuf-3.3.2/autogen.sh > > similarity index 100% > > rename from patches/protobuf-3.3.1/autogen.sh > > rename to patches/protobuf-3.3.2/autogen.sh > > diff --git a/rules/protobuf.make b/rules/protobuf.make > > index 35d065b..97761d7 100644 > > --- a/rules/protobuf.make > > +++ b/rules/protobuf.make > > @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_PROTOBUF) += protobuf > > # > > # Paths and names > > # > > -PROTOBUF_VERSION := 3.3.1 > > -PROTOBUF_MD5 := 20c685147753b515ce380421442044b5 > > +PROTOBUF_VERSION := 3.3.2 > > +PROTOBUF_MD5 := 19ed45d0cbbb88de2c4922978235d314 > > PROTOBUF := protobuf-$(PROTOBUF_VERSION) > > PROTOBUF_SUFFIX := tar.gz > > PROTOBUF_URL := > > https://github.com/google/protobuf/archive/v$(PROTOBUF_VERSION).$(PROTOBUF_SUFFIX) > > If I download protobuf-3.3.2 today from this URL, I get a different MD5sum: > > $ md5sum src/protobuf-3.3.2.tar.gz > ef2a6a6bb3b92d8fa8d71e3cef741f2f src/protobuf-3.3.2.tar.gz > > The contents of the file look very legit though (no accidental HTML error or > such). It definitely contains something very similar to your protobuf-3.3.2 > AFAICS. Are github download archives MD5-stable? Am I opening some ugly can of > worms here, or is there some serious security issue going on?
I have the file with the old md5 and got the new one with your md5. The content is identical. So far github URLs were quite stable. I hope this doesn't start a new trend. I'll add the new md5 to the rule. Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected]
