On Fri, Jun 22, 2018 at 07:50:04AM +0000, Denis OSTERLAND wrote:
> Am Freitag, den 22.06.2018, 09:13 +0200 schrieb Michael Olbrich:
> > >  
> > > +ifdef PTXCONF_AVAHI_BROWSE
> > > + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse)
> > I just pushed a change that installs several tools including avahi-browse.
> > Unless you see a good reason to split those up, I'd like to keep it that
> > way.
> Seems I forgot to pull yesterday before I sent the emails, sorry.
> AVAHI_UTILS is good.

I probably pushed this to the public git after you sent the patch.

> > > 
> > > + @$(call install_link, avahi, avahi-browse, 
> > > /usr/bin/avahi-browse-domains)
> > What's the reason for this link?
> > 
> > Michael
> Thats a convenience function, "avahi-browse-domains" is equal to 
> "avahi-browse -D".
> So it is not really needed, but nice to have.
> Are you willing to add the link, if I send you the patch?

Sure, just add this explanation to the commit message.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to