Am Donnerstag, den 13.12.2018, 14:34 +0100 schrieb Michael Olbrich: > On Thu, Dec 13, 2018 at 01:02:50PM +0000, Baeuerle, Florian wrote: > > Am Donnerstag, den 13.12.2018, 12:16 +0100 schrieb Michael Olbrich: > > > On Wed, Dec 12, 2018 at 02:52:54PM +0000, Baeuerle, Florian wrote: > > > > The version shipped by ptxdist allows us to override the modification > > > > time in the lzop headers. > > > > > > > > Signed-off-by: Florian Bäuerle <[email protected]> > > > > --- > > > > platforms/barebox.in | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/platforms/barebox.in b/platforms/barebox.in > > > > index 645366e93..46ab32a07 100644 > > > > --- a/platforms/barebox.in > > > > +++ b/platforms/barebox.in > > > > @@ -12,7 +12,7 @@ menuconfig BAREBOX > > > > select HOST_LIBUSB if BAREBOX_NEEDS_HOST_LIBUSB > > > > select HOST_OPENSSL if BAREBOX_NEEDS_HOST_OPENSSL > > > > select HOST_IMX_CST if BAREBOX_NEEDS_HOST_IMX_CST > > > > - select HOST_LZOP if BAREBOX_NEEDS_HOST_LZOP > > > > + select HOST_LZOP if BAREBOX_NEEDS_HOST_LZOP || > > > > !SETUP_DISABLE_REPRODUCIBLE > > > > > > This does not work. You will need to enable BAREBOX_NEEDS_HOST_LZOP > > > manually if lzop is used by barebox. > > > > Oops, you're right – in the platformconfig menu all SETUP_ symbols seem to > > be > > undefined. Anyway, it's probably a bad idea to depend on regenerating a > > platformconfig when the user en/disables user properties. > > > > Can I just make barebox unconditionally depend on HOST_LZOP? > > > > Other suggestions? > > Why not leave it as is? lzop is not always used in barebox. You should > enable BAREBOX_NEEDS_HOST_LZOP if lzop compression is used in barebox. > That's the use-case for this option. >
Yes it's an option, but if ptxdist does reproducible by default, then it's a bit misleading that the user has to enable a ptxdist switch if barebox is using lzop to actually get reproducible binaries. Cannot think of any good solution though (other than stating this in the help text maybe?). - Florian _______________________________________________ ptxdist mailing list [email protected]
