On Wed, Jun 05, 2019 at 02:54:14PM +0200, Juergen Borleis wrote:
> Signed-off-by: Juergen Borleis <[email protected]>
> ---
>  rules/nfsutils.in   | 12 +++++++++---
>  rules/nfsutils.make |  2 +-
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/rules/nfsutils.in b/rules/nfsutils.in
> index bd1052ebb..ed62b6d08 100644
> --- a/rules/nfsutils.in
> +++ b/rules/nfsutils.in
> @@ -9,11 +9,15 @@ menuconfig NFSUTILS
>       select RPCBIND                  if RUNTIME
>       select LIBTIRPC                 if GLOBAL_IPV6
>       select ROOTFS_PROTOCOLS         if NFSUTILS_CLIENT
> +     select ROOTFS_VAR_LIB           if RUNTIME
> +     select SYSTEMD                  if RUNTIME && NFSUTILS_SYSTEMD_UNIT
>       help
>         The Sun Network Filesystem (NFS) protocol provides transparent remote
>         access to shared files across networks. The NFS protocol is designed
>         to be portable across different machines, operating systems, network
>         architectures, and transport protocols.
> +       Note: this package expects write permissions to '/var/lib/nfs' for
> +       its state information.
>  
>  if NFSUTILS
>  
> @@ -27,18 +31,20 @@ config NFSUTILS_SERVER
>       bool
>       prompt "server"
>       help
> -       Install all tools and daemons to run a NFS server.
> +       Install all tools and daemons to run an NFS server.
>  
>  config NFSUTILS_NFSD_STARTSCRIPT
>       bool
> -     depends on NFSUTILS_SERVER
> +     depends on NFSUTILS_SERVER && !INITMETHOD_SYSTEMD

Same as with samba.

>       default y
>       prompt "install /etc/init.d/nfsd"
>  
>  config NFSUTILS_SYSTEMD_UNIT
>       bool
>       default y
> -     depends on SYSTEMD
> +     depends on INITMETHOD_SYSTEMD

Hmm, originally all these options depended on SYSTEMD. That was before
INITMETHOD_SYSTEMD was fully established I think and later just copy/paste.
At some point this changed because packages needed so select SYSTEMD.

I think changing this makes sense but should happen globally for all
packages.

Michael

>       prompt "install systemd unit files"
> +     help
> +       Install all systemd related unit files to run the 'nfsutils'.
>  
>  endif
> diff --git a/rules/nfsutils.make b/rules/nfsutils.make
> index 929f53c72..4ce01c4e3 100644
> --- a/rules/nfsutils.make
> +++ b/rules/nfsutils.make
> @@ -76,7 +76,7 @@ $(STATEDIR)/nfsutils.targetinstall:
>       @$(call install_fixup, nfsutils,PRIORITY,optional)
>       @$(call install_fixup, nfsutils,SECTION,base)
>       @$(call install_fixup, nfsutils,AUTHOR,"Robert Schwebel 
> <[email protected]>")
> -     @$(call install_fixup, nfsutils,DESCRIPTION,missing)
> +     @$(call install_fixup, nfsutils,DESCRIPTION,"Network Filesystem 
> Support")
>  
>       @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/nfsstat)
>       @$(call install_copy, nfsutils, 0, 0, 0755, -, /usr/sbin/nfsiostat)
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> [email protected]

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to