On Sat, Nov 16, 2019 at 11:08:47AM +0100, Michael Olbrich wrote:
> On Fri, Nov 15, 2019 at 08:19:24PM +0100, Ladislav Michl wrote:
> > On Sun, Oct 27, 2019 at 07:30:51AM +0100, Michael Olbrich wrote:
> > > On Sat, Oct 26, 2019 at 01:09:28AM +0200, Ladislav Michl wrote:
[...]
> > > > See quick attempt bellow. Problem with SCons is that install stage
> > > > has to be called with exactly the same env as build stage, otherwise
> > > > package is rebuild. Alternatively we can leave everything to install
> > > > stage.
> > >
> > > This looks good. Or maybe just drop pkg_install_env. It's deprecated
> >
> > Seems patch was modified to run scons at compile stage as well. What is
> > the justification of such a change?
>
> Compiling should happen in the compile stage. Otherwise, thinks like
> parallel building does not work correctly. It does not work correctly yet
> for scons because I need to sanitize the parallel building options for
> non-make tools, but that's on my todo list.
Fair enough although now commit message does not reflect code :)
> And I looked at gpsd. Scons is not the reason why stuff is rebuild during
> install: There is a header that is recreated every time scons is called
> :-/.
Well, scons runs config stage each time some target is called :-/ (that's
why compile and install env settings has to be the same).
ladis
_______________________________________________
ptxdist mailing list
[email protected]
