Hi Denis, Den man. 25. nov. 2019 kl. 09.44 skrev Denis OSTERLAND <denis.osterl...@diehl.com>: > > +choice > > + prompt "Generate environment image" > > + default U_BOOT_NONE_ENV_IMAGE > > + help > > + U-Boot from version 2018.03 support out-of-tree environment > > + image generation. > > + > > +config U_BOOT_NONE_ENV_IMAGE > looks a little bit odd. > I would expect a common prefix, with the choice at the end. > U_BOOT_ENV_IMAGE_NONE > U_BOOT_ENV_IMAGE_DEFAULT > U_BOOT_ENV_IMAGE_CUSTOM > > But that´s not a show stopper, I think.
Okay, I see what you mean, a little bit less Yoda :) > > +ifdef PTXCONF_U_BOOT_DEFAULT_ENV_IMAGE > > + $(U_BOOT_MAKE_ENV) $(U_BOOT_DIR)/scripts/get_default_envs.sh > > $(U_BOOT_BUILD_DIR) | \ > > + $(U_BOOT_BUILD_DIR)/tools/mkenvimage \ > > + $(call ptx/ifdef,PTXCONF_U_BOOT_ENV_IMAGE_REDUNDANT,-r,) \ > > + -s $(PTXCONF_U_BOOT_ENV_IMAGE_SIZE) \ > > + -o $(U_BOOT_BUILD_DIR)/u-boot-env.img - > > +endif > > +ifdef PTXCONF_U_BOOT_CUSTOM_ENV_IMAGE > > + $(U_BOOT_BUILD_DIR)/tools/mkenvimage \ > > + $(call ptx/ifdef,PTXCONF_U_BOOT_ENV_IMAGE_REDUNDANT,-r,) \ > > + -s $(PTXCONF_U_BOOT_ENV_IMAGE_SIZE) \ > > + -o $(U_BOOT_BUILD_DIR)/u-boot-custom-env.img \ > I see no need for a different env image name here. > Custom or default is the choice how to generate the image. > It is easier to pass the images to your factory if the have always the same > name. > This gives you the chance to change image type, without a need to change > production flow. Check, one image to rule them all. > > - @rm -vf $(IMAGEDIR)/u-boot.imx > > + @rm -vf $(IMAGEDIR)/u-boot.imx $(IMAGEDIR)/u-boot-dtb.imx > Why u-boot-dtb.imx sneaks in here? Have i missed something? My mistake, I will move it to a separate bugfix patch. /Bruno _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de
