Hello Guillermo,

Am Donnerstag, 12. Dezember 2019, 17:30:58 CET schrieb Guillermo Rodríguez:
> Adds support for copying u-boot.stm32 (u-boot with STM32 image header)
> to the platform image directory. This is used by STM32MP1 SoCs.
> 
> Signed-off-by: Guillermo Rodriguez <[email protected]>
> ---
>  platforms/u-boot.in | 7 +++++++
>  rules/u-boot.make   | 5 ++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index aab9c57a3..1d682d1c3 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -220,5 +220,12 @@ config U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
>         Installing the U-Boot binary which contains as well the SPL and PBL.
>         Say yes if you are building for Layerscape SoCs
> 
> +config U_BOOT_INSTALL_U_BOOT_STM32
> +     prompt "install u-boot.stm32"
> +     bool
> +     help
> +       Installing the U-Boot image with stm32 header (u-boot.stm32) into
> platform +      image directory. Say yes if you are building for STM32MP1 SOC.
> +
>  endif

Trailing whitespace and lines longer than 80 chars.

> 
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 04d801fc6..57d69e15f 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -167,6 +167,9 @@ ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_WITH_SPL_PBL
>       @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-with-spl-pbl.bin \
>               $(IMAGEDIR)/u-boot-with-spl-pbl.bin
>  endif
> +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_STM32
> +     @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot.stm32
> $(IMAGEDIR)/u-boot.stm32 +endif
>  ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE
>       @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-env.img \
>               $(IMAGEDIR)/u-boot-env.img
> @@ -197,7 +200,7 @@ $(STATEDIR)/u-boot.clean:
>       @rm -vf $(IMAGEDIR)/u-boot.img $(IMAGEDIR)/SPL $(IMAGEDIR)/MLO
>       @rm -vf $(IMAGEDIR)/u-boot.imx $(IMAGEDIR)/u-boot-dtb.imx
>       @rm -vf $(IMAGEDIR)/u-boot-env.img
> -     @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> +     @rm -vf $(IMAGEDIR)/u-boot-dtb.bin $(IMAGEDIR)/u-boot-with-spl-pbl.bin
> $(IMAGEDIR)/u-boot.stm32

Also long line here. Otherwise fine, so:

Reviewed-by: Alexander Dahl <[email protected]>

Greets
Alex

> 
>  #
> ---------------------------------------------------------------------------
> - # oldconfig / menuconfig



_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to