On Wed, Feb 26, 2020 at 06:45:55PM +0100, Michael Olbrich wrote:
> On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote:
> > I am not sure if the following patch is what was intended with the change
> > to OOT=KEEP change for kernel. We have a folder within our BSP with a
> > kernel tree and we symlink to that folder using local_src/kernel.
> > <platformname> and local_src/kernel-header.<platformname>.
> > 
> > We use an external kernel source tree and kernel headers from the same
> > folder. It seems with our kernel at least building the kernel-headers in
> > tree causes the out-of-tree kernel to fail to build.
> 
> It's a valid use-case. Can you make the commit message a bit more generic
> (no 'we' or 'I' but a general description of the use-case).
> 
> Also, the signed-of-by is missing.
> 
> And something (probably your mail program) broke the patch. There are a lot
> of descriptions online, on how to send patches with various mail programs.
> If that doesn't work then a patch as attachment is ok as well.

Of which I learned recently: https://git-send-email.io/

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | [email protected]     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to