On Tue, Mar 31, 2020 at 05:17:04AM +0000, Denis Osterland-Heim wrote:
> Hi Michael,
> 
> Am Montag, den 30.03.2020, 21:39 +0200 schrieb Michael Olbrich:
> > On Mon, Mar 30, 2020 at 04:27:48PM +0000, Denis Osterland-Heim wrote:
> > > NetworkManager pppd compile support seems broken.
> > > 
> > > ../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: 
> > > pppd/eui64.h: No such file or directory
> > >    34 | #include <pppd/eui64.h>
> > >       |          ^~~~~~~~~~~~~~
> > > compilation terminated.
> > > 
> > > It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
> > > but this header is not installed to sysroot-target/usr/include/pppd
> > > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18
> > 
> > It's added here:
> > 
> > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L180
> this solves the puzzle.
> eui64.h is only installed if GLOBAL_IPV6 is selected, but NetworkManager pppd
> depends on it unconditionally.
> 
> Shall we go with "select" or "depends on" in case of this global setting?

Yes, but add a comment that shows up when it is disabled and the option is
invisible, so that users know what to do.

> > 
> > > Does anyone use it?
> > 
> > The file is installed and building the NetworkManager pppd support works in
> > my build everything test.
> I should have known this. sorry

:-)

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to