On Fri, Jun 05, 2020 at 11:27:57AM +0200, Ladislav Michl wrote: > On Fri, Jun 05, 2020 at 10:41:37AM +0200, Michael Olbrich wrote: > > On Thu, Jun 04, 2020 at 08:32:40AM +0200, Ladislav Michl wrote: > > > Use (rt)netlink interface provided by 'ip' tool by default. > > > > > > Signed-off-by: Ladislav Michl <[email protected]> > > > --- > > > rules/openvpn.in | 13 +++++++------ > > > rules/openvpn.make | 2 +- > > > 2 files changed, 8 insertions(+), 7 deletions(-) > > > > > > diff --git a/rules/openvpn.in b/rules/openvpn.in > > > index 6958e2940..afa124e10 100644 > > > --- a/rules/openvpn.in > > > +++ b/rules/openvpn.in > > > @@ -9,11 +9,10 @@ menuconfig OPENVPN > > > select IPTABLES if OPENVPN_INSTALL_SAMPLE_CONFIGS && > > > RUNTIME > > > select IPTABLES_INSTALL_TOOLS if OPENVPN_INSTALL_SAMPLE_CONFIGS && > > > RUNTIME > > > select BRIDGE_UTILS if OPENVPN_INSTALL_SAMPLE_SCRIPTS && > > > RUNTIME > > > - select IPROUTE2 if !BUSYBOX_IP && RUNTIME > > > - select IPROUTE2_IP if !BUSYBOX_IP && RUNTIME > > > - select BUSYBOX_IFCONFIG if RUNTIME > > > - select BUSYBOX_NETSTAT if RUNTIME > > > - select BUSYBOX_ROUTE if RUNTIME > > > + select BUSYBOX_FEATURE_IP_LINK if BUSYBOX_IP && RUNTIME > > > + select BUSYBOX_FEATURE_IP_ROUTE if BUSYBOX_IP && RUNTIME > > > + select IPROUTE2 if !BUSYBOX && RUNTIME > > > + select IPROUTE2_IP if !BUSYBOX && RUNTIME > > > > Why not just leave the !BUSYBOX_IP here? Then the comment below is not > > needed because either IPROUTE2_IP or IPROUTE2_IP will be selected. > > We need to select A or B, but there is no simple way of doing this. > When BUSYBOX is not used, then IPROUTE2_IP is the only option, but > with BUSYBOX selected, that leads to IPROUTE2_IP being silently selected. > This way user is warned about pulling another package and can act > accordingly.
That's ok, we silently select packages all the time :-). > Note that we cannot select BUSYBOX_IP anyway (circular dependency), > so this is at least consistent :-) Yes I know. This stuff is always messy. > However, I do not have strong opinion here, so let me send v2. Thanks. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected] To unsubscribe, send a mail with subject "unsubscribe" to [email protected]
