On Tue, Jun 16, 2020 at 03:30:33PM +0200, Marco Felsch wrote: > Hi Bastian, Roland, > > thanks for the quick response and comments :) > > On 20-06-16 10:34, Bastian Krause wrote: > > > > On 6/16/20 10:02 AM, Roland Hieber wrote: > > > On Tue, Jun 16, 2020 at 12:56:18AM +0200, Marco Felsch wrote: > > >> Allow users to specify other barebox image naming schemes. Now users can > > >> specify a list of: > > >> - unique image names and/or > > >> - matching name patterns using wildcards. > > >> > > >> While on it I fixed the leaking image-results upon a 'ptxdist clean > > >> barebox' command. Now all barebox artefacts are removed from the > > >> $(IMAGEDIR). > > >> > > >> Signed-off-by: Marco Felsch <[email protected]> > > >> --- > > > > > > LGTM on first glance, could you do the same for > > > rules/templates/template-barebox-make too please? > > > > Is this really necessary? The idea of the barebox rule template is to > > generate a BSP specific barebox rule, right? We already have.. > > > > BAREBOX_@PACKAGE@_IMAGES := @image@ > > > > ..in that template, so we don't really benefit from a config option here. > > My idea was to _hopefully_ remove the usage of this template and > instead use ptxdist upstream mechanism: > - layer -> different barebox configs > - this patch -> different barebox images
I think it would still be good to have this template in the future. For example, in DistroKit, we have one platform which targets ARM-v7A boards, and we can use the same kernel and userland here. But we still need different barebox packages because we cannot target multiple board families with one barebox config - in that case one barebox for Broadcom BCM283x boards, one for ARM Vexpress, one for i.MX6, one for OMAP is needed, even though they are all ARM-v7A platforms. Otherwise we would need to introduce additional platforms, which would unnecessarily duplicate the space needed to build images for all boards. - Roland -- Roland Hieber, Pengutronix e.K. | [email protected] | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected] To unsubscribe, send a mail with subject "unsubscribe" to [email protected]
