On Tue, Sep 22, 2020 at 10:17:43AM +0200, Michael Olbrich wrote:
> On Tue, Sep 22, 2020 at 12:17:25AM +0200, Roland Hieber wrote:
> > The root.tgz is needed for all other rootfs images, so it makes sense to
> > build it by default. Also provide at least one image by default for
> > newly added platforms.
> 
> No. Unused default stuff is never disabled unless it actually breaks
> things. So in BSPs that don't actually use this, the image will probably
> built anyways and just wastes space and time.

OK, I'll add it to the new init_defconfig instead.

 - Roland

> 
> Michael
> 
> > Signed-off-by: Roland Hieber <[email protected]>
> > ---
> >  platforms/image-root-tgz.in | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/platforms/image-root-tgz.in b/platforms/image-root-tgz.in
> > index c325209ded6d..cfd4f3f83600 100644
> > --- a/platforms/image-root-tgz.in
> > +++ b/platforms/image-root-tgz.in
> > @@ -2,9 +2,10 @@
> >  
> >  menuconfig IMAGE_ROOT_TGZ
> >     tristate
> > +   default y
> >     prompt "Generate images/root.tgz      "
> >     help
> > -     FIXME
> > +     Build a tar.gz archive containing the root file system.
> >  
> >  if IMAGE_ROOT_TGZ
> >  
> > -- 
> > 2.28.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > [email protected]
> > To unsubscribe, send a mail with subject "unsubscribe" to 
> > [email protected]
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Roland Hieber, Pengutronix e.K.          | [email protected]     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]
To unsubscribe, send a mail with subject "unsubscribe" to 
[email protected]

Reply via email to