On Tue, May 11, 2021 at 10:08:29AM +0200, Philipp Zabel wrote: > On Mon, 2021-05-10 at 12:19 +0200, Philipp Zabel wrote: > > - add Zstandard compression support, allows to enable the > > kernel CONFIG_MODULE_COMPRESS_ZSTD option > > - LIBKMOD_ZSTD selects HOST_LIBKMOD_ZSTD so depmod understands > > Zstandard during kernel build > > > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > --- > > rules/host-libkmod.in | 8 ++++++++ > > rules/host-libkmod.make | 1 + > > rules/libkmod.in | 8 ++++++++ > > rules/libkmod.make | 5 +++-- > > 4 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/rules/host-libkmod.in b/rules/host-libkmod.in > > index dc03abc2a2ab..a32c0e353b19 100644 > > --- a/rules/host-libkmod.in > > +++ b/rules/host-libkmod.in > > @@ -2,4 +2,12 @@ > > > > config HOST_LIBKMOD > > tristate > > + select HOST_ZSTD if HOST_LIBKMOD_ZSTD > > default y if ALLYES > > + > > +if HOST_LIBKMOD > > + > > +config HOST_LIBKMOD_ZSTD > > + bool > > + > > +endif > > diff --git a/rules/host-libkmod.make b/rules/host-libkmod.make > > index 57c8b2ecf9f9..1438eda33424 100644 > > --- a/rules/host-libkmod.make > > +++ b/rules/host-libkmod.make > > @@ -32,6 +32,7 @@ HOST_LIBKMOD_CONF_OPT := \ > > --disable-coverage \ > > --without-xz \ > > --without-zlib \ > > + --$(call ptx/wwo, PTXCONF_HOST_LIBKMOD_ZSTD)-zstd \ > > --without-openssl > > > > # > > ---------------------------------------------------------------------------- > > diff --git a/rules/libkmod.in b/rules/libkmod.in > > index 1660f7c4b58b..80590a9d0d81 100644 > > --- a/rules/libkmod.in > > +++ b/rules/libkmod.in > > @@ -3,6 +3,8 @@ > > menuconfig LIBKMOD > > tristate > > select ZLIB if LIBKMOD_ZLIB > > + select ZSTD if LIBKMOD_ZSTD > > Of course this is also missing: > > + select HOST_LIBKMOD if LIBKMOD_ZSTD > > > + select HOST_LIBKMOD_ZSTD if LIBKMOD_ZSTD
Please align the 'if's. > Would this be the correct way to enable Zstandard support in depmod > during kernel build? It's not easy to find when building the kernel fails, but I don't have a better idea either. But please do the same thing for zlib support to make this consistent. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-requ...@pengutronix.de
