On Sun, Jul 18, 2021 at 09:03:13PM +0200, Lars Pedersen wrote:
> Hi. Thanks for the feedbacks.
> 
> On Fri, 16 Jul 2021 at 15:02, Michael Olbrich <[email protected]> 
> wrote:
> >
> > On Fri, Jul 16, 2021 at 02:53:42PM +0200, Lars Pedersen wrote:
> > > Hi. Thanks for the reply
> > >
> > > On Fri, 16 Jul 2021 at 14:41, Michael Olbrich <[email protected]> 
> > > wrote:
> > > >
> > > > On Mon, Jul 12, 2021 at 01:09:09PM +0200, Lars Pedersen wrote:
> > > > > Signed-off-by: Lars Pedersen <[email protected]>
> > > > > ---
> > > > > Changes since v1:
> > > > >  - Updated LICENSE field to BSD-2-Clause
> > > > >
> > > > >  rules/python3-pysnmp.in   | 13 ++++++++++
> > > > >  rules/python3-pysnmp.make | 54 
> > > > > +++++++++++++++++++++++++++++++++++++++
> > > > >  2 files changed, 67 insertions(+)
> > > > >  create mode 100644 rules/python3-pysnmp.in
> > > > >  create mode 100644 rules/python3-pysnmp.make
> > > > >
> > > > > diff --git a/rules/python3-pysnmp.in b/rules/python3-pysnmp.in
> > > > > new file mode 100644
> > > > > index 000000000..09e9b2b0a
> > > > > --- /dev/null
> > > > > +++ b/rules/python3-pysnmp.in
> > > > > @@ -0,0 +1,13 @@
> > > > > +## SECTION=python3
> > > > > +
> > > > > +config PYTHON3_PYSNMP
> > > > > +     bool
> > > > > +     prompt "pysnmp"
> > > > > +     select PYTHON3
> > > > > +     select HOST_PYTHON3_SETUPTOOLS
> > > > > +     select PYTHON3_PLY
> > > > > +     select PYTHON3_PYASN1
> > > > > +     select PYTHON3_PYCRYPTODOMEX
> > > > > +     select PYTHON3_PYSMI
> > > > > +     help
> > > > > +       pySNMP is a cross-platform, pure-Python SNMP engine 
> > > > > implementation.
> > > > > diff --git a/rules/python3-pysnmp.make b/rules/python3-pysnmp.make
> > > > > new file mode 100644
> > > > > index 000000000..9eb101b9f
> > > > > --- /dev/null
> > > > > +++ b/rules/python3-pysnmp.make
> > > > > @@ -0,0 +1,54 @@
> > > > > +# -*-makefile-*-
> > > > > +#
> > > > > +# Copyright (C) 2021 by Lars Pedersen <[email protected]>
> > > > > +#
> > > > > +# For further information about the PTXdist project and license 
> > > > > conditions
> > > > > +# see the README file.
> > > > > +#
> > > > > +
> > > > > +#
> > > > > +# We provide this package
> > > > > +#
> > > > > +PACKAGES-$(PTXCONF_PYTHON3_PYSNMP) += python3-pysnmp
> > > > > +
> > > > > +#
> > > > > +# Paths and names
> > > > > +#
> > > > > +PYTHON3_PYSNMP_VERSION       := 4.4.12
> > > > > +PYTHON3_PYSNMP_MD5   := 2222880259daf6e2cb322e938c818276
> > > > > +PYTHON3_PYSNMP               := pysnmp-$(PYTHON3_PYSNMP_VERSION)
> > > > > +PYTHON3_PYSNMP_SUFFIX        := tar.gz
> > > > > +PYTHON3_PYSNMP_URL   := $(call ptx/mirror-pypi, pysnmp, 
> > > > > $(PYTHON3_PYSNMP).$(PYTHON3_PYSNMP_SUFFIX))
> > > > > +PYTHON3_PYSNMP_SOURCE        := 
> > > > > $(SRCDIR)/$(PYTHON3_PYSNMP).$(PYTHON3_PYSNMP_SUFFIX)
> > > > > +PYTHON3_PYSNMP_DIR   := $(BUILDDIR)/$(PYTHON3_PYSNMP)
> > > > > +PYTHON3_PYSNMP_LICENSE       := BSD-2-Clause
> > > > > +PYTHON3_PYSNMP_LICENSE_FILES := \
> > > > > +     file://LICENSE.rst;md5=b15d29f500f748d1c2a15709769090a8
> > > > > +
> > > > > +# 
> > > > > ----------------------------------------------------------------------------
> > > > > +# Prepare
> > > > > +# 
> > > > > ----------------------------------------------------------------------------
> > > > > +
> > > > > +PYTHON3_PYSNMP_CONF_TOOL     := python3
> > > > > +
> > > > > +# 
> > > > > ----------------------------------------------------------------------------
> > > > > +# Target-Install
> > > > > +# 
> > > > > ----------------------------------------------------------------------------
> > > > > +
> > > > > +$(STATEDIR)/python3-pysnmp.targetinstall:
> > > > > +     @$(call targetinfo)
> > > > > +
> > > > > +     @$(call install_init, python3-pysnmp)
> > > > > +     @$(call install_fixup, python3-pysnmp,PRIORITY,optional)
> > > > > +     @$(call install_fixup, python3-pysnmp,SECTION,base)
> > > > > +     @$(call install_fixup, python3-pysnmp,AUTHOR,"Lars Pedersen 
> > > > > <[email protected]>")
> > > > > +     @$(call install_fixup, python3-pysnmp,DESCRIPTION,missing)
> > > > > +
> > > > > +     @$(call install_glob,python3-pysnmp, 0, 0, -, \
> > > > > +             /usr/lib/python$(PYTHON3_MAJORMINOR)/site-packages,, 
> > > > > *.pyc)
> > > >
> > > > That's the strange one. Why skip all *.pyc? I can do a fixup if this
> > > > should just be *.py instead.
> > >
> > > Yes now I remember.  I couldn't get the pyc files to work on the
> > > device and somehow the py files did. After a few hours of debugging I
> > > gave up.
> >
> > In that case, please at a short comment above the install_glob about this.
> > And more details in the commit message. Something about how it fails, the
> > error message etc.
> > Basically something that whoever updates the package in the future can use
> > to check if it's still broken.
> >
> > Michael
> >
> 
> Okay I'll do a re-test and see if it still the case. Is it okay to
> resend a v3 for pysmp, or do I need to resend the entire patch series
> in v3?

If you do it soon, then just the one (as a reply to this thread) is fine.
Just don't wait too long or I'll forget to apply the rest of the series
:-).

Regards,
Michael


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]
To unsubscribe, send a mail with subject "unsubscribe" to 
[email protected]

Reply via email to