On 9/29/21 13:26, Michael Olbrich wrote: > On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote: >> Let old and trusty module-init-tools handle zlib compressed kernel modules. > > Any reason why you use this instead of libkmod? The module-init-tools are > no longer maintained, so I would actually prefer to move the package to > staging and remove it eventually. Unless there is a specific use-case for > them that does not work with libkmod? > > Michael >
Nope. No reason. Just compressed module support in case someone uses it. I don't mind either way. But if it doesn't move to staging then you might as well add compressed module support? I see no harm. While we're at it.. Why "staging" for obsoleted packages? How about obsolete for obsolescence and staging for the fashionable kids? I think it makes it a whole lot clearer if you're unfamiliar with whatever package. >> --- >> rules/module-init-tools.in | 7 +++++++ >> rules/module-init-tools.make | 4 +++- >> 2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/rules/module-init-tools.in b/rules/module-init-tools.in >> index 765de6b97..010f68bf2 100644 >> --- a/rules/module-init-tools.in >> +++ b/rules/module-init-tools.in >> @@ -4,6 +4,7 @@ >> menuconfig MODULE_INIT_TOOLS >> tristate >> prompt "module-init-tools " >> + select ZLIB if MODULE_INIT_TOOLS_ZLIB >> help >> This package contains a set of programs for loading, inserting >> and removing kernel modules for Linux (versions 2.5.48 and >> @@ -11,6 +12,12 @@ menuconfig MODULE_INIT_TOOLS >> >> if MODULE_INIT_TOOLS >> >> +config MODULE_INIT_TOOLS_ZLIB >> + bool >> + prompt "zlib compression support" >> + help >> + Enable support for gz compressed kernel modules >> + >> config MODULE_INIT_TOOLS_INSMOD >> bool >> prompt "Install insmod on target" >> diff --git a/rules/module-init-tools.make b/rules/module-init-tools.make >> index a4aa68175..da5a892bf 100644 >> --- a/rules/module-init-tools.make >> +++ b/rules/module-init-tools.make >> @@ -35,7 +35,9 @@ MODULE_INIT_TOOLS_MAKEVARS := MAN5="" MAN8="" >> # >> # autoconf >> # >> -MODULE_INIT_TOOLS_AUTOCONF := $(CROSS_AUTOCONF_USR) >> +MODULE_INIT_TOOLS_AUTOCONF := \ >> + $(CROSS_AUTOCONF_USR) \ >> + --$(call ptx/endis, PTXCONF_MODULE_INIT_TOOLS_ZLIB)-zlib-dynamic >> >> # >> ---------------------------------------------------------------------------- >> # Target-Install >> -- >> 2.30.2 >> >> >> _______________________________________________ >> ptxdist mailing list >> [email protected] >> To unsubscribe, send a mail with subject "unsubscribe" to >> [email protected] >> > _______________________________________________ ptxdist mailing list [email protected] To unsubscribe, send a mail with subject "unsubscribe" to [email protected]
