On Fri, Nov 26, 2021 at 10:36:25AM +0100, Philipp Zabel wrote:
> On Thu, 2021-11-25 at 17:11 +0100, Michael Olbrich wrote:
> [...]
> > > + select SYSTEMD                          if MEDIA_SESSION_SYSTEMD
> [...]
> > > +config MEDIA_SESSION_SYSTEMD
> > > + bool
> [...]
> > 
> > > +config MEDIA_SESSION_SYSTEMD_UNIT_USER
> > > + bool
> > > + default y
> > > + depends on INITMETHOD_SYSTEMD
> > 
> >             && SYSTEMD_UNITS_USER
> 
> This would cause a dependency loop:
> 
> .../rules/systemd.in:3:error: recursive dependency detected!
> .../rules/systemd.in:3:       symbol SYSTEMD is selected by 
> MEDIA_SESSION_SYSTEMD
> .../rules/media-session.in:21:        symbol MEDIA_SESSION_SYSTEMD is 
> selected by MEDIA_SESSION_SYSTEMD_UNIT_USER
> .../rules/media-session.in:31:        symbol MEDIA_SESSION_SYSTEMD_UNIT_USER 
> depends on SYSTEMD_UNITS_USER
> .../rules/systemd.in:100:     symbol SYSTEMD_UNITS_USER depends on SYSTEMD
> 
> pulseaudio.in has "default y if SYSTEMD_UNITS_USER" instead.
> 
> dbus.in has an invisible option DBUS_SYSTEMD_USER_UNIT that depends on
> SYSTEMD_UNITS_USER and DBUS_SYSTEMD_UNIT
> 
> Should this follow either of those?

Now that I think about it, just default to the corresponding PIPEWIRE
option without a prompt. It's only used in combination with that anyways.

Michael

> [...]
> > +MEDIA_SESSION_MODULES := \
> 
> unused?
> [...]
> > +MEDIA_SESSION_SPA_MODULES := \
> 
> unused?
> 
> Ouch, copy&paste-from-pipewire.make error, will remove.
> 
> [...]
> > +   @$(call install_copy, media-session, 0, 0, 644, -, 
> > /usr/share/pipewire/media-session.d/alsa-monitor.conf)
> > +   @$(call install_copy, media-session, 0, 0, 644, -, 
> > /usr/share/pipewire/media-session.d/bluez-monitor.conf)
> > +   @$(call install_copy, media-session, 0, 0, 644, -, 
> > /usr/share/pipewire/media-session.d/media-session.conf)
> > +   @$(call install_copy, media-session, 0, 0, 644, -, 
> > /usr/share/pipewire/media-session.d/v4l2-monitor.conf)
> 
> break the lines.
> 
> Ok.
> 
> regards
> Philipp
> 
> _______________________________________________
> ptxdist mailing list
> [email protected]
> To unsubscribe, send a mail with subject "unsubscribe" to 
> [email protected]
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]
To unsubscribe, send a mail with subject "unsubscribe" to 
[email protected]

Reply via email to