On Sat, Jan 29, 2022 at 09:29:43AM +0100, Christian Melki wrote: > On 1/28/22 19:32, Michael Olbrich wrote: > > On Fri, Jan 28, 2022 at 06:22:19PM +0100, Christian Melki wrote: > >> On 1/28/22 17:16, Michael Olbrich wrote: > >>> On Thu, Jan 27, 2022 at 03:35:30PM +0100, Christian Melki wrote: > >>>> Approx. 2,5 year worth of fixes. > >>>> https://github.com/tpm2-software/tpm2-tss/releases > >>>> Fixes CVE-2020-24455 (three times over). > >>>> tpm2-tss now depends on JSON_C and LIBCURL. > >>>> Remove changed configuration options. > >>> > >>> Fails to build here: > >>> > >>> checking for groupadd... no > >>> configure: error: Missing required program 'groupadd': ensure it is > >>> installed and on PATH. > >>> > >>> Adding a group should not be done during install anyways and it would > >>> fail, > >>> so I think this should work: > >>> > >>> TPM2_TSS_CONF_ENV := \ > >>> $(CROSS_ENV) \ > >>> GROUPADD=: \ > >>> USERADD=: > >>> > >>> Michael > >>> > >> > >> Didn't see that one coming. How abusive! > >> From a makefile none the less. > >> I have the required binaries on my development machine so I didn't notice. > >> Now, I've tried your suggestion, but I can't see that it helps? > >> > >> Looks like the entire thing goes about the binaries in a very static > >> fashion. > >> > >> .. > >> define make_tss_user_and_group > >> (id -g tss 2>/dev/null || groupadd -r tss) && \ > >> (id -u tss 2>/dev/null || useradd -r -g tss tss) > >> endef > > > > @$(call make_tss_user_and_group) || echo "WARNING Failed to create the > > tss user and group" > > > > so any error here is ignored. We just need to get through the configure > > check. > > > > ack. > > TPM2_TSS_CONF_ENV := \ > $(CROSS_ENV) \ > ac_cv_prog_result_groupadd=yes \ > ac_cv_prog_result_useradd=yes > > should work for getting through configure?
I think so. You should see a "(cached)" in the configure output for those checks. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected] To unsubscribe, send a mail with subject "unsubscribe" to [email protected]
