Hello Andreas,

before you send v3, I have some nitpicking here.  Maybe you want to
consider that, too.

Am Wed, Oct 18, 2023 at 12:55:44PM +0200 schrieb Andreas Helmcke:
> Bugfixes and several changes. e.g.
> - Stronger TLS defaults
> - HTTP/2 Support now as optional module
> - Some former modules are now build in
> 
> Link: https://www.lighttpd.net/2023/1/3/1.4.68/
> Link: https://www.lighttpd.net/2023/2/10/1.4.69/
> Link: https://www.lighttpd.net/2023/5/10/1.4.70/
> Link: https://www.lighttpd.net/2023/5/27/1.4.71/
> Link: https://www.lighttpd.net/2023/10/6/1.4.72/
> 
> Signed-off-by: Andreas Helmcke <[email protected]>

You can remove the empty line between Link: and Signed-off-by: – Link
is one of the tags documented in the Linux kernel submitting patches
guide.

> ---
>  rules/lighttpd.in   | 26 +++-----------------------
>  rules/lighttpd.make |  9 +++------
>  2 files changed, 6 insertions(+), 29 deletions(-)
> 
> diff --git a/rules/lighttpd.in b/rules/lighttpd.in
> index 910271087..9e2b4c97a 100644
> --- a/rules/lighttpd.in
> +++ b/rules/lighttpd.in
> @@ -69,12 +69,12 @@ endmenu
>  
>  menu "modules                     "
>  
> -config LIGHTTPD_MOD_ACCESS
> +config LIGHTTPD_MOD_H2
>       bool
> -     prompt "mod_access"
> +     prompt "mod_h2"
>       default y
>       help
> -       Deny access to some files.
> +       HTTP/2 support

Please keep the alphabetic ordering when adding new entries.

>  
>  config LIGHTTPD_MOD_ACCESSLOG
>       bool
> @@ -83,12 +83,6 @@ config LIGHTTPD_MOD_ACCESSLOG
>       help
>         flexible logging of requests served
>  
> -config LIGHTTPD_MOD_ALIAS
> -     bool
> -     prompt "mod_alias"
> -     help
> -       Specify a special document-root for a given url-subset.
> -
>  config LIGHTTPD_MOD_AUTH
>       bool
>       prompt "mod_auth"
> @@ -123,12 +117,6 @@ config LIGHTTPD_BZ2LIB
>         Enable bzip2 support for mod_deflate.
>  endif
>  
> -config LIGHTTPD_MOD_FASTCGI
> -     bool
> -     prompt "mod_fastcgi"
> -
> -if LIGHTTPD_MOD_FASTCGI
> -
>  config LIGHTTPD_MOD_FASTCGI_PHP
>       bool
>       depends on PHP8_SAPI_CGI
> @@ -140,8 +128,6 @@ config LIGHTTPD_MOD_FASTCGI_PHP
>  comment "PHP CGI SAPI must be enabled"
>       depends on !PHP8_SAPI_CGI
>  
> -endif
> -
>  config LIGHTTPD_MOD_MAGNET
>       bool
>       select LIGHTTPD_LUA
> @@ -149,12 +135,6 @@ config LIGHTTPD_MOD_MAGNET
>       help
>         A module to control the request handling
>  
> -config LIGHTTPD_MOD_REWRITE
> -     bool
> -     prompt "mod_rewrite"
> -     help
> -       Module for URL rewriting
> -
>  config LIGHTTPD_MOD_WEBDAV
>       bool
>       prompt "mod_webdav"
> diff --git a/rules/lighttpd.make b/rules/lighttpd.make
> index 3aa54a1fb..9ff8b3ea7 100644
> --- a/rules/lighttpd.make
> +++ b/rules/lighttpd.make
> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd
>  #
>  # Paths and names
>  #
> -LIGHTTPD_VERSION     := 1.4.67
> -LIGHTTPD_MD5         := 64822c5061001673162cf9775d91a80b
> +LIGHTTPD_VERSION     := 1.4.72
> +LIGHTTPD_MD5         := 466f9fe131cd7d38d0fe47d2e6a2939d
>  LIGHTTPD             := lighttpd-$(LIGHTTPD_VERSION)
>  LIGHTTPD_SUFFIX              := tar.xz
>  LIGHTTPD_URL         := 
> http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX)
> @@ -93,16 +93,13 @@ $(STATEDIR)/lighttpd.install:
>  # 
> ----------------------------------------------------------------------------
>  
>  LIGHTTPD_MODULES-y :=
> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESS)              += mod_access
> +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_H2)                  += mod_h2

Same here, this list is sorted alphabetically, keep that.

Greets
Alex

>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESSLOG)   += mod_accesslog
> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ALIAS)               += mod_alias
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH)                += mod_auth
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH)                += 
> mod_authn_file
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DEFLATE)     += mod_deflate
> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_FASTCGI)     += mod_fastcgi
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_MAGNET)              += mod_magnet
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_OPENSSL)         += mod_openssl
> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_REWRITE)     += mod_rewrite
>  LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_WEBDAV)              += mod_webdav
>  LIGHTTPD_MODULES-y += $(call remove_quotes,$(PTXCONF_LIGHTTPD_MOD_EXTRA))
>  
> -- 
> 2.39.2
> 
> 

Reply via email to