Hi Benjamin, On Thu, 29 Aug 2024 11:38:23 +0000, Benjamin Gaignard wrote: > If LCMS package dependency is selected build weston color management > module. > > Signed-off-by: Benjamin Gaignard <[email protected]> > --- > rules/weston.in | 1 + > rules/weston.make | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/rules/weston.in b/rules/weston.in > index 10f0e9172..22752aef0 100644 > --- a/rules/weston.in > +++ b/rules/weston.in > @@ -40,6 +40,7 @@ menuconfig WESTON > select PIPEWIRE if WESTON_BACKEND_PIPEWIRE > select NEATVNC if WESTON_BACKEND_VNC > select PAM if WESTON_BACKEND_VNC > + select LCMS > prompt "weston " > help > Wayland compositor reference implementation > diff --git a/rules/weston.make b/rules/weston.make > index 35ddab180..908f76f0b 100644 > --- a/rules/weston.make > +++ b/rules/weston.make > @@ -45,7 +45,7 @@ WESTON_CONF_OPT := \ > -Dbackend-vnc=$(call ptx/truefalse,PTXCONF_WESTON_BACKEND_VNC) \ > -Dbackend-wayland=$(call ptx/truefalse,PTXCONF_WESTON_GL) \ > -Dbackend-x11=false \ > - -Dcolor-management-lcms=false \ > + -Dcolor-management-lcms=$(call ptx/truefalse, PTXCONF_LCMS) \
With this change, it's not possible to build Weston without color-management-lcms, because PTXCONF_LCMS is always selected and this always will be set to true. Please add a separate option PTXCONF_WESTON_COLOR_MANAGEMENT_LCMS (or similar) that enables this option, and select LCMS only if PTXCONF_WESTON_COLOR_MANAGEMENT_LCMS is set. Michael > -Ddemo-clients=$(call ptx/truefalse,PTXCONF_WESTON_IVISHELL_EXAMPLE) \ > -Ddeprecated-color-management-colord=false \ > -Ddeprecated-color-management-static=false \ > -- > 2.43.0 > > >
