On Fr, 2025-03-07 at 13:01 +0100, Michael Olbrich wrote:
> > @@ -128,6 +128,9 @@ 
> > MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_PANFROST)       += panfrost
> >  endif
> >  MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_SWRAST)            += 
> > swrast
> >  MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_VIRTIO)            += 
> > virtio
> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_NOUVEAU)   += nouveau
> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_ASAHI)             += asahi
> 
> That one is only available on ARM64 hardware right? So maybe restrict it to
> that.

Wrapped in ifdef PTXCONF_ARCH_ARM64 in v2, it's currently disabled
anyway due to a missing dependency on target LIBCLC by way of
MESALIB_DRI_ASAHI.

> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_GFXSTREAM) += gfxstream
> 
> Fails to build on ARMv7 with:
> 
> ../mesa-25.0.1/src/gfxstream/guest/vulkan_enc/ResourceTracker.cpp:4905:23: 
> error: format '%p' expects argument of type 'void*', but argument 4 has type 
> 'VkFence' {aka 'long long unsigned int'} [-Werror=format=]
> 
> We should probably only build it for 64-bit architectures
> (PTXCONF_ARCH_LP64). I don't see it beeing used anywhere else anyways.

Wrapped in ifdef PTXCONF_ARCH_LP64 in v2.

regards
Philipp

Reply via email to