On Mon, Aug 6, 2012 at 7:13 PM, Kang-Hao (Kenny) Lu <[email protected]> wrote: > (12/08/06 19:25), Lachlan Hunt wrote: >> On 2012-08-06 13:08, Kang-Hao (Kenny) Lu wrote: >> I'd rather find a way to address the issue. I've just been a bit busy >> with other tasks for the last 2 weeks to look into this. >> >> I'd like feedback from implementers about how best to address the issue. >> The options I can think of: >> >> 1. Disallow all comments within the selector for this API. Throw >> SyntaxError when they are used. >> 2. Allow comments, but define that unclosed comments should throw a >> SyntaxError. >> 3. Allow comments, define that unclosed comments are silently ignored. > > Both 1. and 2. would take some extra code in Gecko, in particular 1. I'd > note that this is not just about comments. It's about EOF fixing. See > [1] for other testcases. > > [1] http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0524 > > (12/08/07 0:20), Tab Atkins Jr. wrote: >> Officially, 2.1 defines Kenny's example of "html /*" as tokenizing >> into IDENT WS DELIM DELIM, which is then an invalid selector since >> nothing recognizes those two delims as part of Selector's syntax. > > No, that's IDENT WS(S) BAD_COMMENT
Ah, whoops, indeed. I forgot that BAD_COMMENT existed. >> This is compatible with Syntax's treatment, where it's recognized as a >> comment, but triggers a parse error. > > COMMENT is a bit special here and I think you might want to comment on > other cases in [1]. Hm, kk. ~TJ
