> On 17 Jun 2015, at 18:11, Kostiainen, Anssi <anssi.kostiai...@intel.com> > wrote: > >> On 02 Jun 2015, at 00:58, timeless <timel...@gmail.com> wrote: >> >> http://www.w3.org/TR/2015/WD-appmanifest-20150212/ > > Thanks for the detailed review. The pull request with you review feedback > baked in is at: > > https://github.com/w3c/manifest/pull/383 > > The changes should land after being reviewed, assuming no concerns.
The changes you proposed have landed: http://w3c.github.io/manifest/ [...] >>> 8.4 src member >>> Let value be the result of calling the [[GetOwnProperty]] internal method >>> of icon passing "src" as the argument. >>> Let type be Type(value). >>> If type is not "string", >>> or value is the empty string, then: >> ^ this specific or branch isn't really necessary, one could just fall >> through to the Trim path... >>> If type is not "undefined", issue a developer warning that the type is >>> unsupported. >>> Return undefined. >>> If Trim(value) is the empty string, then return undefined. >> >> (I didn't read past this point) Any further feedback would be much appreciated. For example, a similar, very detailed review for the remaining parts of the document. Thanks, -Anssi
