Travis, Great. Glad to hear that you are working on the tests.
Perhaps you can try Simon' method to make your update in a new branch in w3c/web-platform-tests, so that others can make updates together. Thanks, Zhiqiang From: Travis Leithead [mailto:[email protected]] Sent: Monday, December 21, 2015 11:44 PM To: Simon Pieters <[email protected]>; public-webapps <[email protected]>; Zhang, Zhiqiang <[email protected]>; Yves Lafon <[email protected]> Subject: RE: Can we land heycam's WebIDL tests as-is and address review comments following? Yves and I have been reviewing these tests and revising them according to recent WebIDL changes and we think they may be ready to be integrated. The updates are in a PR on heycams page. Let's not integrate heycam's original PR until our update is done first please... From: Simon Pieters<mailto:[email protected]> Sent: Monday, December 21, 2015 1:13 AM To: public-webapps<mailto:[email protected]>; Zhang, Zhiqiang<mailto:[email protected]> Subject: Re: Can we land heycam's WebIDL tests as-is and address review comments following? On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang <[email protected]<mailto:[email protected]>> wrote: > Hi, > > 2+ years ago, heycam submitted WebIDL tests at > > https://github.com/w3c/web-platform-tests/pull/271 > > These tests have been reviewed by several guys but get no update ever > since. > > I wonder if we could land the tests as-is and address the review > comments in further pull requests? Then we can make a test suite to > advance the specification and for people to understand the specification. > > Thoughts? > > Thanks, > Zhiqiang Personally I don't object to that plan, but an alternative is to create a new branch in w3c/web-platform-tests with these changes, and anyone with push access to w3c/web-platform-tests can make changes to that branch, and then we can merge to master when it's ready. git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force git checkout -b webidl-tests origin/pr/271 git push -u origin webidl-tests -- Simon Pieters Opera Software
