On Mon, Mar 8, 2010 at 2:17 PM, Joseph Scott <[email protected]> wrote: > Confirmed, I've just committed version 0.1.5 of PuSHPress that calls > verify_request for unsubscribe requests as well (and removes the hard > coded subscribe mode from the verification process). > > Thanks for pointing this out. I should go back and re-read the spec > again, apparently things didn't sink in well enough the first few > dozen times :-(
No worries! Even the best reading of specs has its issues. This is why we have a hub test suite: http://code.google.com/p/pubsubhubbub/wiki/HubTestSuite And also why it's good your code was open source, so we can all review it! -Brett > On Mon, Mar 8, 2010 at 2:57 PM, James Holderness <[email protected]> wrote: >> Do you mean this one? >> http://plugins.trac.wordpress.org/browser/pushpress/trunk/class-pushpress.php?rev=212708#L221 >> >> I was asking about *unsbuscribe* requests, and that just seems to be >> verifying *subscribe* requests. The hub.mode parameter is always set >> to "subscribe" and the function isn't called when unsubscribing. > > > > -- > Joseph Scott > [email protected] > http://josephscott.org/ >
