We (me and Sean) merged the PR and did the changes needed to fix some side effects.
I am sending this to inform that all Puppet stuff was dropped and that we are good without it. Cheers On Tue, Jan 3, 2017 at 5:00 PM, Elyezer Rezende <[email protected]> wrote: > I went ahead and created this PR [1] it is covering installing the base > packages like gcc, git, etc. > > [1] https://github.com/pulp/pulp_packaging/pull/270 > > On Tue, Jan 3, 2017 at 4:33 PM, Elyezer Rezende <[email protected]> > wrote: > >> It also seems that we can remove the ci/deploy [1] directory entirely. I >> tried to find a place where any of those scripts were called and at least >> on the jobs they are not being called. I used git grep to help me with that >> so I may be missing something. >> >> [1] https://github.com/pulp/pulp_packaging/tree/master/ci/deploy >> >> On Tue, Jan 3, 2017 at 4:28 PM, Elyezer Rezende <[email protected]> >> wrote: >> >>> The only puppet apply is for the pulp-unittest [1] puppet module. >>> Looking on its source code it seems to be just setting up some packages >>> depending on the slave OS. >>> >>> We can either install them on the prepare_node.sh or create an ansible >>> playbook for it. Or even have both, for example I think it is valuable to >>> have on the base nodes the following packages: >>> >>> * git >>> * gcc >>> * python-devel >>> * python-pip >>> * redhat-lsb >>> * wget >>> * ruby-devel (not sure about this one, but can be needed) >>> >>> Other packages like: >>> >>> * tito >>> * rpm-build >>> * python-{paste,lxml,argparse,..} >>> * mongodb >>> * qpid >>> >>> Can be installed as needed by the jobs. >>> >>> I will wait for opinions before I make a plan to get this done. >>> >>> [1] https://github.com/pulp/pulp_packaging/blob/master/ci/de >>> ploy/utils/puppet/pulp-unittest.pp >>> >>> On Tue, Jan 3, 2017 at 2:35 PM, Brian Bouterse <[email protected]> >>> wrote: >>> >>>> +1 to pulling out puppet to unblock the builds. >>>> +1 to replacing any puppet usage with Ansible, which is consistent with >>>> the current direction[0]. >>>> >>>> After digging around in git some, it looks like those puppet lines were >>>> originally added in 2015 with this commit[1]. That commit both installs >>>> puppet and runs some `puppet apply ...` statements, so pulling puppet out >>>> should be fine as long as those `puppet apply` statements get replaced with >>>> something else (either Ansible, or $ANOTHER_IDEA). >>>> >>>> Thank you for raising this and whatever you can do on it. >>>> >>>> [0]: https://www.redhat.com/archives/pulp-list/2016-November/msg0 >>>> 0045.html >>>> [1]: https://github.com/pulp/pulp_packaging/commit/e1657129d04470 >>>> b2c302a91051c821a2e7283a6f >>>> >>>> On Mon, Jan 2, 2017 at 9:58 AM, Elyezer Rezende <[email protected]> >>>> wrote: >>>> >>>>> The prepare_node script is responsible to prepare the nodepool nodes >>>>> we use on Jenkins. Other than installing basic packages and the machinery >>>>> to make the node a Jenkins slave it installs puppet [1]. >>>>> >>>>> I am wondering why setting up puppet is needed since it seems to be >>>>> related to the unittest jobs only. I am wondering that because there is no >>>>> Puppet for Fedora 25 yet [2] and that is blocking us to have Fedora 25 >>>>> nodes since they can't be built. >>>>> >>>>> With all that said, I have some questions: >>>>> >>>>> 1) Can we drop puppet setup and let the jobs that need it to set it up? >>>>> 2) Can we move away from Puppet to Ansible? If yes, what needs to be >>>>> done to have that? >>>>> >>>>> I am raising this up because I want to test Pulp ASAP on Fedora 25 and >>>>> I don't know all the details about the Puppet need on the slaves. >>>>> >>>>> Thank you >>>>> >>>>> [1] https://github.com/pulp/pulp_packaging/blob/master/ci/no >>>>> depool/scripts/prepare_node.sh#L20-L54 >>>>> [2] https://yum.puppetlabs.com/ >>>>> >>>>> -- >>>>> Elyézer Rezende >>>>> Senior Quality Engineer >>>>> irc: elyezer >>>>> >>>>> _______________________________________________ >>>>> Pulp-dev mailing list >>>>> [email protected] >>>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>>> >>>>> >>>> >>> >>> >>> -- >>> Elyézer Rezende >>> Senior Quality Engineer >>> irc: elyezer >>> >> >> >> >> -- >> Elyézer Rezende >> Senior Quality Engineer >> irc: elyezer >> > > > > -- > Elyézer Rezende > Senior Quality Engineer > irc: elyezer > -- Elyézer Rezende Senior Quality Engineer irc: elyezer
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
