+1 https://pulp.plan.io/issues/2870
On Mon, Jul 3, 2017 at 2:08 PM, David Davis <[email protected]> wrote: > +1 from me. > > At the very least, we could try it out for a while and see how it goes. > > > David > > On Mon, Jul 3, 2017 at 1:05 PM, Brian Bouterse <[email protected]> > wrote: > >> @daviddavis thanks for the flake8 fixes. >> >> I was thinking we should enable pep8speaks [1] for all of our branches >> and repos. We can still have Travis or other places run flake8 but that >> would put it right in the PR comments. >> >> [1]: https://github.com/OrkoHunter/pep8speaks >> >> On Mon, Jul 3, 2017 at 12:03 PM, David Davis <[email protected]> >> wrote: >> >>> I just merged a PR to fix flake8 on the 3.0-dev branch of Pulp[0]. It >>> also fixes the flake8 warnings that came up while flake8 was not running in >>> Travis. >>> >>> If you’re developing Pulp 3, please rebase your branch with 3.0-dev from >>> upstream. Also for bonus points, check the Travis logs for your PRs to make >>> sure flake8 is running on the entire codebase and not via “git diff…”. >>> >>> Let me know if you need any help. >>> >>> Thanks! >>> >>> [0] https://github.com/pulp/pulp/pull/3019 >>> >>> David >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> [email protected] >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >>> >> > > _______________________________________________ > Pulp-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
