I don’t think the pagination changes would break the pulp-smash tests. The default page size would still remain 100. Also, looks like the page_handler code relies on the ‘next’ field which would still exist. It would just be a different parameter in the href (page vs cursor).
Agreed that introducing breaking changes in beta is unfortunate. However, if we want to change this, now is our only option. David On Tue, Jun 26, 2018 at 10:31 AM Jeremy Audet <jau...@redhat.com> wrote: > FYI, Pulp Smash integrates closely with Pulp's current pagination > behaviour: > > - The page_handler > > <http://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.api.html#pulp_smash.api.page_handler> > response handler walks through pages of results and collects them into a > single list. It's used extensively. > - The pagination test case > > <http://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.tests.pulp3.file.api_v3.test_pagination.html> > "assumes that Pulp returns 100 elements in each page of results. This is > configurable, but the current default set by all known Pulp installers." > > If pagination behaviour is changed, then this will break a significant > number of tests. Also, introducing breaking changes into a fundamental > aspect of Pulp's API during beta would be unfortunate. > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
