It sounded like from the discussion on that issue that the translation would likely happen before so it's unlikely we'd run into the exact usecase that throws the error.
Still, definitely need to be careful where we use them and not forget that it won't work with gettext. --Dana Dana Walker Associate Software Engineer Red Hat <https://www.redhat.com> <https://red.ht/sig> On Fri, Oct 5, 2018 at 11:29 AM, David Davis <davidda...@redhat.com> wrote: > I’d love to use f-strings as they seem to offer a speed improvement and > are IMO more readable. However, I did some research and it looks like we > can’t use them with gettext: > > https://bugs.python.org/issue33189 > > Which is rather unfortunate. I suppose in those rare cases where we use an > interpolated string that doesn’t require translation, we could use > f-strings. > > David > > > On Fri, Oct 5, 2018 at 11:15 AM Kersom <ker...@redhat.com> wrote: > >> Since support for Python 3.5 was dropped. Perhaps we could evaluate Pulp >> 3 adopt the new features supported by Python3.6 only, such as f'strings.[0] >> >> Just a suggestion. >> >> [0] https://docs.python.org/3/reference/lexical_analysis.html#f-strings >> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> > > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
