Austin worded it better than me :) That's what I was trying to get at. My bad.
Also I was going to suggest a POC branch to get some more real world data on the impact, but he kind of beat me to it as well. So much for hitting send before re-reading my thoughts. On Tue, Jun 4, 2019 at 1:44 PM Austin Macdonald <aus...@redhat.com> wrote: > > > On Tue, Jun 4, 2019 at 1:40 PM Matt Pusateri <mpusa...@redhat.com> wrote: > >> >> >> >> On Tue, Jun 4, 2019 at 1:15 PM Mike DePaulo <mikedep...@redhat.com> >> wrote: >> >>> On Tue, Jun 4, 2019 at 12:09 PM Robin Chan <rc...@redhat.com> wrote: >>> >>>> Mike, clarification question below... >>>> >>>> On Tue, Jun 4, 2019 at 11:45 AM Mike DePaulo <mikedep...@redhat.com> >>>> wrote: >>>> >>>>> On Tue, Jun 4, 2019 at 9:14 AM Brian Herring <bherr...@redhat.com> >>>>> wrote: >>>>> >>>>>> > Moreover, using black would effectively take style comments/noise >>>>>> out of PR reviews and we could just focus on logic. >>>>>> >>>>>> QE looked into this for a while, and I think it is a WONDERFUL >>>>>> addition... especially for the reasons stated above. >>>>>> >>>>>> Some tweaking would be needed, but it is one less item to worry about. >>>>>> >>>>>> +1 >>>>>> >>>>> [...] >>>>> >>>>> +1 based on my experiences on the X2Go project. >>>>> We don't want to turn off new contributors with style issues. >>>>> >>>> Meaning new contributors would be annoyed that PR reviews would be full >>>> of stylistic comments and that would be a bad experience? >>>> I read this as possibly meaning new contributors would be unhappy with >>>> the black project style choices? Being unfamiliar with the X2Go project, >>>> I'd like some clarification on your input to the discussion here. TIA. >>>> >>> >>> The former. New contributors being annoyed by stylistic comments. >>> I think they would likely be unhappy with the black project style >>> choices as well, but that would be outweighed. >>> >>> >> This makes me wonder. >> >> 1. What is the ratio of external(non-redhat) committer/contributors? >> Meaning if 90% of the code comes from RH, is this really a problem? I'm >> not saying that RH should flex its muscle and influence the community, but >> I am wondering if we're over-thinking it? Is this a real problem or a >> perceived problem. >> 2. Wouldn't you argue that enforcing style guides is the "right thing to >> do" because it improves code and quality in the long run? And it theory >> should also make it easier for new contributors to get involved as there is >> consistency of code style due the guidelines? >> >> > There may be some confusion here. Black doesn't just tell us when > something is wrong, it fixes formatting for you. So we have a situation > where the code is more consistent *and* easier to contribute. (Unless it > does something crazy in our particular case.) > > >> Matt P. >> >> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
