-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/25/2011 09:30 AM, Jeff Ortel wrote: > All, > > Be aware that I'm in the process of changing the xxApi.update() > semantics as described here: > https://engineering.redhat.com/trac/mgmt-integrated/wiki/PulpUpdateSemantics. > This involves changes to the Api.update() itself and the corresponding > WS controller. Also, we have a lot of unit tests that hack on model > objects then call update() expecting it to just be stored instead of > calling the proper API method (which was probably added after the test > was written). As I work through the unit tests, I'm replacing calls to > Api.update() with the proper call if it exists. But, in some cases > there is none so I'm replacing with Model.get_collection().save().
+1, this is a really good call to replace calls to update to the collection calls themselves now that we have them. That'll keep things clean in terms of side effects. > I'm starting with the RepoApi because it's the poster child for this and > probably doing ConsumerApi next. I'll push after each API is done to > minimize merge conflicts. > > I'm also converting to using Model.get_collection() instead of BaseApi > CRUD methods while I'm there. > > -jeff > > _______________________________________________ > Pulp-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-list - -- Jay Dobies RHCE# 805008743336126 Freenode: jdob http://pulpproject.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNZ71QAAoJEOMmcTqOSQHCMaMIAKXWG1kibNPhVfxGVjSgLqOo 1MSgojxUHkUJ0edhtrLUeC1bJfYS5s4PupwbB6sT14fYMiwDNznGGoKMpqpDW/yA JgKIYtDNWwIDCGddctwJz15uQGTCmdaQzI+du+x08bt6dnfPk8gkdx5eEuJM7DSY mmWErrSnu4vpWrWlpOV+eN4TEb2AG2WVc3PDZxY79IutmLyp0Yf9FcKBVf30iVde aAo4sna9vaqJl0amHNFjpBjz7vKwxuGvo3yjQLKecutNGbYZcyh7wSv3FnSYMQZI mvjKsNIdfgYrcZtdxKMK8aHLU7p2LtEgb3swRGPVb1EFtdbWbfj+LpTUhwmRCGw= =+rrv -----END PGP SIGNATURE----- _______________________________________________ Pulp-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-list
