https://bugs.freedesktop.org/show_bug.cgi?id=53066
Bug #: 53066
Summary: echo-cancel: sink_request_rewind_cb() forwards the
rewind request without converting the rewind amount
between sample specs
Classification: Unclassified
Product: PulseAudio
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: medium
Component: modules
AssignedTo: [email protected]
ReportedBy: [email protected]
QAContact: [email protected]
CC: [email protected]
The code of sink_request_rewind_cb():
/* Called from sink I/O thread context */
static void sink_request_rewind_cb(pa_sink *s) {
struct userdata *u;
pa_sink_assert_ref(s);
pa_assert_se(u = s->userdata);
if (!PA_SINK_IS_LINKED(u->sink->thread_info.state) ||
!PA_SINK_INPUT_IS_LINKED(u->sink_input->thread_info.state))
return;
pa_log_debug("Sink request rewind %lld", (long long)
s->thread_info.rewind_nbytes);
/* Just hand this one over to the master sink */
pa_sink_input_request_rewind(u->sink_input,
s->thread_info.rewind_nbytes, TRUE, FALSE,
FALSE);
}
If it's possible that the master sink has a different sample spec than the echo
cancel sink, then passing s->thread_info.rewind_nbytes is wrong if it's not
first converting to the master sink sample spec.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.
_______________________________________________
pulseaudio-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs
