Tanu Kaskinen pushed to branch master at PulseAudio / pulseaudio
Commits: fd9e3452 by Felipe Sateler at 2019-05-28T16:16:49Z i18n: Don't compile with -ffast-math This flag results in calls to (at least) isfinite() and isnan() becoming skipped, and a constant false returned. This caused volume-test to fail on Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916504 Since PulseAudio deals with negative infinities with volume dB values, this is not a problem only in volume-test. We shouldn't use -ffast-math at all. - - - - - 1 changed file: - configure.ac Changes: ===================================== configure.ac ===================================== @@ -175,7 +175,7 @@ AX_CHECK_COMPILE_FLAG([-std=gnu11], [-pedantic -Werror]) AX_APPEND_COMPILE_FLAGS( - [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option -fdiagnostics-color=auto], + [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -fno-common -fdiagnostics-show-option -fdiagnostics-color=auto], [], [-pedantic -Werror]) AS_CASE([" $CFLAGS "], [*" -O0 "*], [], [ View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b You're receiving this email because of your account on gitlab.freedesktop.org.
_______________________________________________ pulseaudio-commits mailing list pulseaudio-commits@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits
