On Fri, 15.09.06 17:23, Igor Zubkov ([EMAIL PROTECTED]) wrote: > Hello, All! > > patch in attach! (for svn version)
Looks fine to me. However I have a few issues: - Isn't there a setlocale() call missing in the main() functions? - Could you please put the #if ENABLE_NLS stuff into its own header file in src/pulsecore/nls.h (or something like that). It seems like quite a lot of non-trivial code that would be needed to be copied into each source file. In addition I fear that the #ifdef stuff could get even more complicating the more operating systems we support (i.e. win32, macosx) - From the comments in the acinclude files I get the impression that many of them are actually superfluous with current autotools versions. Could you please look into that and only include the minium m4 files in the patch. Otherwise it looks fine. Thanks for the contribution! Lennart -- Lennart Poettering; lennart [at] poettering [dot] net ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.net/lennart/ _______________________________________________ pulseaudio-discuss mailing list [email protected] https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
