On Sun, Dec 19, 2010 at 2:16 AM, Arun Raghavan
<arun.ragha...@collabora.co.uk> wrote:
> I think this is incorrect - the sentence basically said "the src-*
> resampling methods are provided by libsamplerate - for more details,
> look at the libsamplerate documentation". We could rephrase as:
>
> """
> See the documentation of libsamplerate and speex for explanations of the
> different src- and speex- methods.
> """

Indeed, I think your suggestion is preferable. Here's a patch against
current stable-queue making that change and also correcting the
quality range (incorrectly 0..9 but is 0..10 now).

Best,
-Dan
From 13a54ba888781bb0abfcd1f536dfc73550aefc21 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crim...@ubuntu.com>
Date: Sun, 19 Dec 2010 07:51:21 -0500
Subject: [PATCH] Further clarify src- and speex- references in pulse-daemon.conf

Based on comments from Arun Raghavan, make clear that we're referring
to the libspeex API documentation for the speex- options. Also correct
the quality range (was incorrectly 0..9 but is 0..10 now) and clean up
the line length.

Signed-off-by: Daniel T Chen <crim...@ubuntu.com>
---
 man/pulse-daemon.conf.5.xml.in |   27 ++++++++++++++-------------
 1 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in
index 8164106..8c22f9b 100644
--- a/man/pulse-daemon.conf.5.xml.in
+++ b/man/pulse-daemon.conf.5.xml.in
@@ -90,19 +90,20 @@ USA.
       <opt>trivial</opt>, <opt>speex-float-N</opt>,
       <opt>speex-fixed-N</opt>, <opt>ffmpeg</opt>. See the
       documentation of libsamplerate and speex for explanations of the
-      different src- methods. The method <opt>trivial</opt> is the most basic
-      algorithm implemented. If you're tight on CPU consider using
-      this. On the other hand it has the worst quality of them
-      all. The Speex resamplers take an integer quality setting in the
-      range 0..9 (bad...good). They exist in two flavours: <opt>fixed</opt> and
-      <opt>float</opt>. The former uses fixed point numbers, the latter relies on
-      floating point numbers. On most desktop CPUs the float point
-      resmampler is a lot faster, and it also offers slightly better
-      quality. See the output of <opt>dump-resample-methods</opt> for
-      a complete list of all available resamplers. Defaults to
-      <opt>speex-float-3</opt>. The <opt>--resample-method</opt>
-      command line option takes precedence. Note that some modules
-      overwrite or allow overwriting of the resampler to use.</p>
+      different src- and speex- methods, respectively. The method
+      <opt>trivial</opt> is the most basic algorithm implemented. If
+      you're tight on CPU consider using this. On the other hand it has
+      the worst quality of them all. The Speex resamplers take an
+      integer quality setting in the range 0..10 (bad...good). They
+      exist in two flavours: <opt>fixed</opt> and <opt>float</opt>. The former uses fixed point
+      numbers, the latter relies on floating point numbers. On most
+      desktop CPUs the float point resampler is a lot faster, and it
+      also offers slightly better quality. See the output of
+      <opt>dump-resample-methods</opt> for a complete list of all
+      available resamplers. Defaults to <opt>speex-float-3</opt>. The
+      <opt>--resample-method</opt> command line option takes precedence.
+      Note that some modules overwrite or allow overwriting of the
+      resampler to use.</p>
     </option>
 
     <option>
-- 
1.7.1

_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Reply via email to