Hi, I have attached a patch with several small fixes to PA's Vala bindings: Let me explain my changes:
1. PA uses Vala's ``Posix'' package (see line 23 of libpulse.vapi).
These dependencies have to be declared in the *.deps file.
2. Fix obvious C&P error.
3. Rename the parameter to match the C function. This simplifies
understanding what this parameter means.
4. According to the official documentation[1] the ``dev'' parameter
may be NULL as this is the default. Change the method definition
accordingly.
If you don't have any objections, please merge this patch into master.
Best regards
Alexander Kurtz
[1]
http://0pointer.de/lennart/projects/pulseaudio/doxygen/stream_8h.html#ab9544f6677af133fbe81bf8a21eb489c
diff -Naur old/vala/libpulse.deps new/vala/libpulse.deps
--- old/vala/libpulse.deps 1970-01-01 01:00:00.000000000 +0100
+++ new/vala/libpulse.deps 2011-03-21 21:00:13.513867865 +0100
@@ -0,0 +1 @@
+posix
diff -Naur old/vala/libpulse.vapi new/vala/libpulse.vapi
--- old/vala/libpulse.vapi 2011-03-20 23:31:50.000000000 +0100
+++ new/vala/libpulse.vapi 2011-03-21 21:07:43.850868270 +0100
@@ -237,7 +237,7 @@
[CCode (cname="PA_CHANNELS_MAX")]
public const int CHANNELS_MAX;
- [CCode (cname="PA_CHANNELS_MAX")]
+ [CCode (cname="PA_RATE_MAX")]
public const int RATE_MAX;
[CCode (cname="pa_cvolume")]
@@ -854,7 +854,7 @@
public int iterate(bool block = true, out int retval = null);
public int run(out int retval = null);
public unowned MainLoopApi get_api();
- public void quit(int r);
+ public void quit(int retval);
public void wakeup();
public void set_poll_func(PollFunc poll_func);
}
@@ -1194,8 +1194,8 @@
public int is_suspended();
public int is_corked();
- public int connect_playback(string dev, BufferAttr? a = null, Flags flags = 0, CVolume? volume = null, Stream? sync_stream = null);
- public int connect_record(string dev, BufferAttr? a = null, Flags flags = 0);
+ public int connect_playback(string? dev = null, BufferAttr? a = null, Flags flags = 0, CVolume? volume = null, Stream? sync_stream = null);
+ public int connect_record(string? dev = null, BufferAttr? a = null, Flags flags = 0);
public int connect_upload(size_t length);
public int disconnect();
public int finish_upload();
signature.asc
Description: This is a digitally signed message part
_______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
