On 2011-05-15 16:45, Tanu Kaskinen wrote:
On Sun, 2011-05-15 at 17:43 +0300, Tanu Kaskinen wrote:
This was discussed on the mailing list:
https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-May/010091.html
---
src/modules/alsa/alsa-mixer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c
index f236da0..8375a2f 100644
--- a/src/modules/alsa/alsa-mixer.c
+++ b/src/modules/alsa/alsa-mixer.c
@@ -893,7 +893,7 @@ static int element_set_volume(pa_alsa_element *e,
snd_mixer_t *m, const pa_chann
if (e->has_dB) {
long value = to_alsa_dB(f);
- int rounding = value> 0 ? -1 : +1;
+ int rounding = e->direction == PA_ALSA_DIRECTION_OUTPUT ? +1 : -1;
if (e->volume_limit>= 0&& value> (e->max_dB * 100))
value = e->max_dB * 100;
David, are you happy with this change, or does this require more
discussion?
I think it's OK. I think your theory is at least as good as mine, so
let's give it a try. For HDA Intel this does not make much of a
difference as Playback almost always only goes up to 0 dB whereas
Recording usually is above 0 dB (although not always).
Might be worth adding a comment referring to the discussion behind the
reasoning though.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
