#1182: More facts for manufacturer.rb
----------------------------------------+-----------------------------------
Reporter:  dhill                        |        Owner:  community 
    Type:  enhancement                  |       Status:  new       
Priority:  normal                       |    Component:  client    
 Version:  0.24.2                       |     Severity:  normal    
Keywords:  facter, facts, manufacturer  |        Stage:  Unreviewed
   Patch:  Code                         |   Complexity:  Unknown   
----------------------------------------+-----------------------------------
 Playing with Facter, I noticed that while it uses dmidecode (where
 possible) to get things like the manufacturer and productname, it misses
 data like the chassis type (desktop, rack mount etc).

 Attached is a rude and crude patch to implement a few more facts in
 manufacturer.rb.  No test, not sure how to write one yet, or even if one
 is needed for this type of change.

 The optimum solution is probably a configuration file (ini format, ruby
 hash format?) that defines the section and the keys from the section,
 rather than a hard code in the .rb file.  I may be able to provide this in
 a later patch - will start a discussion on the list about that.

-- 
Ticket URL: <http://reductivelabs.com/trac/puppet/ticket/1182>
puppet <http://reductivelabs.com>
Puppet - Portable System Automation
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to